This repository was archived by the owner on Mar 20, 2019. It is now read-only.
Add id_token support for Google OAuth
#371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need support to access
id_tokenfrom the Google authorization endpoint when I getIAuthorizationStateback from DNOA and since there was no way other than modifying the incoming message, that's what I did. I needed this to support migrating my users from OpenId to Google Sign In (OpenId Connect) without pulling out DNOA altogether, which I probably still will do eventually. Hope this helps others, it was a fairly easy change.Note you only need commits acb2b74 and 25e335f for the actual changes.