Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new validation according to: https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3268768
The issuer returned by the call to the OIDC endpoint (.well-known/openid-configuration) is valid if one of the following is true:
The validation behavior was added to
authority.py
, and new tests were added totest_authority.py
to cover itIn addition, a few other tests in
test_authority.py
andtest_application.py
were given valid issuers in their mocked OIDC discovery responses in order to pass validation, but were otherwise unchanged.(this is the full implementation of the work started in this draft PR: #830)