Skip to content

Add claims challenge parameter in initiate_device_flow #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2025
Merged

Add claims challenge parameter in initiate_device_flow #839

merged 6 commits into from
Jul 18, 2025

Conversation

ashok672
Copy link
Contributor

@ashok672 ashok672 commented Jul 15, 2025 •
edited
Loading

Fixes #834

@ashok672 ashok672 requested a review from a team as a code owner July 15, 2025 23:20
rayluo
rayluo requested changes Jul 16, 2025
View reviewed changes
Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some adjustments. You don't have to make changes manually; you can accept them by clicking "accept suggestion".

ashok672 and others added 5 commits July 15, 2025 17:17
@ashok672 @rayluo
Update msal/application.py
ece91b8 
Co-authored-by: Ray Luo <rayluo@microsoft.com>
@ashok672 @rayluo
Update msal/oauth2cli/oauth2.py
40f3c84 
Co-authored-by: Ray Luo <rayluo@microsoft.com>
@ashok672 @rayluo
Update msal/application.py
0788b7d 
Co-authored-by: Ray Luo <rayluo@microsoft.com>
@ashok672
Update oauth2.py
6f75131
@ashok672
Update oauth2.py
17dec56
rayluo
rayluo approved these changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@rayluo rayluo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in advance. Please don't merge it in just yet. Let me fix the build pipeline soon. UPDATE: Fixed.

@rayluo rayluo merged commit 70fd4d1 into dev Jul 18, 2025
24 of 38 checks passed
@rayluo rayluo deleted the asram/support-claims-challenge-device-code-flow branch July 18, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayluo rayluo rayluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Claims challenge doesn't work in device code flow
2 participants
@ashok672 @rayluo