Fix NPE at getClass().getClassLoader() #1345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isopov
force-pushed
the
null-classloader
branch
from
d83effb to
8a99a4f
Compare
|
Hi, I agree with the issue, but your fix is broken. We can't live without a loaded config. A proper fix would be to try ContextClassLoader, Class' ClassLoader and SystemClassLoader until we find a non null one, and then use it to call Could you please fix properly? Cheers |
slandelle
added a commit
that referenced
this pull request
Feb 6, 2017
Motivation: Class::getClassLoader can return null if the Class was loaded by the bootstrap ClassLoader. Modification: Scan all non null ClassLoaders. Result: No more NPE when class was loaded by the bootstrap ClassLoader
|
Sorry, I was on vacation - that fix works well for me, thanks! |
|
Great, thanks for your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to play with async-http-client in jcstress, but AFAIU it uses bootstrap classloader and creating async-http-client fails with NPE.