Parse inverted indexes field names into array of strings #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Go sdk have two properties for each index, which I kind of like: The generic properties for the index is still on the "base" model. The Java SDK have two different methods instead, either you get normal indexes or you get inverted ones. Maybe we should discuss the best way forward in #493? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now IndexApiClient.GetAllCollectionIndexesAsync fails with deserealization issue.
It happens because for persistent indexes only field names are stored and returned as array of strings.
For inverted indexes it's different: there is an object with properties.
My goal was to fix deserealization issue to allow my work to continue as we want to use inverted indexes in our database and using mentioned method for database schema verify.
I do know there is InvertedIndexField model but don't think adding a major change to interface is what is needed for this issue.