wpReasonList-other should not be removed after selecting a reason from the dropdown on Special:MultiLock
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	AntiCompositeNumber
	Mon, Jul 14, 3:23 AM

Description

Steps to replicate the issue (include links if applicable):

Go to https://meta.wikimedia.org/w/index.php?title=Special%3AMultiLock&wpTarget=Example1%0AExample2
Click "View user information"
Select "Cross-wiki abuse" from the Reason dropdown
Try to write additional clarifying information in the lock reason

What happens?:
The free-text box is smoothly animated away.

What should have happened instead?:
The box should remain and allow text to be entered in it.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This appears to have been caused by rECAU4807c178683e: Convert SpecialMultiLock to HTMLForm (@matmarex).

Details

	Subject	Repo	Branch	Lines +/-
	SpecialMultiLock: Change "Reason" field from 'selectorother' to 'selectandother'	mediawiki/extensions/CentralAuth	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: rECAU4807c178683e: Convert SpecialMultiLock to HTMLForm

Event Timeline

AntiCompositeNumber created this task.Mon, Jul 14, 3:23 AM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMon, Jul 14, 3:23 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Johannnes89 subscribed.Mon, Jul 14, 5:39 AM

My bad, sorry.

Change #1169126 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] SpecialMultiLock: Change "Reason" field from 'selectorother' to 'selectandother'

https://gerrit.wikimedia.org/r/1169126

gerritbot added a project: Patch-For-Review.Mon, Jul 14, 1:58 PM

DAlangi_WMF moved this task from Inbox, needs triage to In progress on the MediaWiki-Platform-Team board.Mon, Jul 14, 1:59 PM

Test plan

Before patch applied

Visited the Special:MultiLock
Search for a username using the form (then click "View information")
Get a response with information about the account in (2) above.
The reason field has an input field below the select that disappears once selected.

Screenshot 2025-07-15 at 1.27.05 PM.png (1×3 px, 455 KB)

Screenshot 2025-07-15 at 1.26.55 PM.png (1×2 px, 436 KB)

After the patch is applied

Visited the Special:MultiLock
Search for a username using the form (then click "View information")
Get a response with information about the account in (2) above.
The reason field has an input field below the select that stays once selected, which I think is the expected behavior.

Screenshot 2025-07-15 at 1.27.47 PM.png (1×3 px, 475 KB)

Screenshot 2025-07-15 at 1.28.03 PM.png (1×3 px, 476 KB)

NOTE: The input field for searching user names mentions in the text that the username should be prefixed. I assume it's something like User:Foobar (with the User: prefix), but when I tried that, the username wasn't found. But without the prefix, the search works. Maybe the text should be adjusted?

Screenshot 2025-07-15 at 1.36.49 PM.png (1×2 px, 83 KB)

@matmarex, does the test plan above make sense? If so, I can +2 the patch. :)

Yep, that looks right, thanks.

Change #1169126 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SpecialMultiLock: Change "Reason" field from 'selectorother' to 'selectandother'

https://gerrit.wikimedia.org/r/1169126

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.11; 2025-07-22).Tue, Jul 15, 2:00 PM

DAlangi_WMF closed this task as Resolved.Tue, Jul 15, 2:01 PM

This was useful to read: https://www.mediawiki.org/wiki/Admin_tools_development/CentralAuth_Locking.

Maintenance_bot removed a project: Patch-For-Review.Tue, Jul 15, 2:31 PM

	F64577085: Screenshot 2025-07-15 at 1.36.49 PM.png
	Tue, Jul 15, 12:40 PM

	F64576313: Screenshot 2025-07-15 at 1.28.03 PM.png
	Tue, Jul 15, 12:40 PM

	F64576315: Screenshot 2025-07-15 at 1.27.47 PM.png
	Tue, Jul 15, 12:40 PM

	F64576002: Screenshot 2025-07-15 at 1.26.55 PM.png
	Tue, Jul 15, 12:40 PM

	F64576003: Screenshot 2025-07-15 at 1.27.05 PM.png
	Tue, Jul 15, 12:40 PM