Page MenuHomePhabricator
Create Task
Maniphest T396121

Wikibase CI broken: Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [called from ArticlePlaceholder]
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81/7461/console

1) ArticlePlaceholder\Tests\AboutTopicRendererTest::testTitle
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:109

2) ArticlePlaceholder\Tests\AboutTopicRendererTest::testLanguageLinks
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:118

3) ArticlePlaceholder\Tests\AboutTopicRendererTest::testTemplateUsed
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:126

4) ArticlePlaceholder\Tests\AboutTopicRendererTest::testCreateArticleButton
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:134

5) ArticlePlaceholder\Tests\AboutTopicRendererTest::testCreateArticleButton_ifLabelIsNotAValidTitle
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:142

6) ArticlePlaceholder\Tests\AboutTopicRendererTest::testNoCreateArticleButton_ifUserNotAllowedToCreatePage
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:151

7) ArticlePlaceholder\Tests\AboutTopicRendererTest::testOtherProjectsLinks
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:159

8) ArticlePlaceholder\Tests\AboutTopicRendererTest::testMetaTags
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:96
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/AboutTopicRendererTest.php:168

9) ArticlePlaceholder\Tests\Specials\SpecialAboutTopicIntegrationTest::testExecution
Use of MediaWiki\Output\OutputPage::setLanguageLinks was deprecated in MediaWiki 1.43. [Called from ArticlePlaceholder\AboutTopicRenderer::showLanguageLinks in /workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php at line 281]

/workspace/src/includes/debug/MWDebug.php:386
/workspace/src/includes/debug/MWDebug.php:357
/workspace/src/includes/debug/MWDebug.php:238
/workspace/src/includes/GlobalFunctions.php:782
/workspace/src/includes/Output/OutputPage.php:1608
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:281
/workspace/src/extensions/ArticlePlaceholder/includes/AboutTopicRenderer.php:149
/workspace/src/extensions/ArticlePlaceholder/includes/Specials/SpecialAboutTopic.php:167
/workspace/src/extensions/ArticlePlaceholder/includes/Specials/SpecialAboutTopic.php:131
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:124
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:53
/workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:76
/workspace/src/extensions/ArticlePlaceholder/tests/phpunit/includes/specials/SpecialAboutTopicIntegrationTest.php:127

Presumably caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1149760.

Details

SubjectRepoBranchLines +/-
Replace getLanguageLinks() + setLanguageLinks() with addLanguageLink()mediawiki/extensions/Cognatemaster+6 -7
Replace setLanguageLinks() with addLanguageLinks()mediawiki/extensions/ArticlePlaceholdermaster+1 -1
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 5 2025, 1:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 5 2025, 1:59 PM
gerritbot added a comment.Jun 5 2025, 2:01 PM

Change #1154034 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Replace setLanguageLinks() with addLanguageLinks()

https://gerrit.wikimedia.org/r/1154034

gerritbot added a project: Patch-For-Review.Jun 5 2025, 2:01 PM
gerritbot added a comment.Jun 5 2025, 2:08 PM

Change #1154036 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Cognate@master] Replace getLanguageLinks() + setLanguageLinks() with addLanguageLink()

https://gerrit.wikimedia.org/r/1154036

Lucas_Werkmeister_WMDE added a comment.Jun 5 2025, 2:16 PM

The failed build quibble-daily-Cognate-vendor-mysql-php74 #426 may or may not be related too. (I can definitely see the deprecation warnings in the mw-error.log, but I wouldn’t normally expect that to result in “No valid JSON response” errors as seen in the console, so maybe it’s something else.)

Lucas_Werkmeister_WMDE added a project: Wikidata-Omega (The Board).Jun 5 2025, 2:23 PM
Lucas_Werkmeister_WMDE moved this task from new to the board to Ready for Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Jun 5 2025, 3:13 PM

Change #1154034 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Replace setLanguageLinks() with addLanguageLinks()

https://gerrit.wikimedia.org/r/1154034

Jdforrester-WMF subscribed.Jun 5 2025, 3:21 PM

Sorry for the disruption, I thought I searched before merging but clearly I failed.

gerritbot added a comment.Jun 5 2025, 3:38 PM

Change #1154036 merged by jenkins-bot:

[mediawiki/extensions/Cognate@master] Replace getLanguageLinks() + setLanguageLinks() with addLanguageLink()

https://gerrit.wikimedia.org/r/1154036

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.5; 2025-06-10).Jun 5 2025, 4:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 5 2025, 4:13 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).

I think this is fixed now.

Maintenance_bot removed a project: Patch-For-Review.Jun 5 2025, 4:30 PM
karapayneWMDE moved this task from Newly completed tasks to 2025 Q2 on the Wikidata-Omega (Completed Tasks) board.Wed, Jun 18, 6:32 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits