Page MenuHomePhabricator

Discussion tools add topic shows in page actions menu without an icon
Open, Needs TriagePublicBUG REPORT

Description

In I7b681496e689c22bad1a956e64c12313ae324edb we landed a change that defined icons. This worked a bit too well in Minerva leading to the add topic menu item appearing in Minerva without an icon.

Steps to replicate the issue (include links if applicable):

What happens?:
Add topic button appears with black square icon

image.png (575×1 px, 71 KB)

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1153324 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Suppress "add topic" button in Minerva page actions menu

https://gerrit.wikimedia.org/r/1153324

Change #1153426 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Add speech bubble icon for third parties

https://gerrit.wikimedia.org/r/1153426

Change #1153427 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DiscussionTools@master] Remove the add topic button from the page actions menu via hook

https://gerrit.wikimedia.org/r/1153427

Change #1153324 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Suppress "add topic" button in Minerva page actions menu

https://gerrit.wikimedia.org/r/1153324

Change #1153426 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add speech bubble icon for third parties

https://gerrit.wikimedia.org/r/1153426

Change #1153427 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove the add topic button from the page actions menu via hook

https://gerrit.wikimedia.org/r/1153427