Page MenuHomePhabricator

Upstream nowrap CSS rules for mw-editsection from VE to core
Closed, ResolvedPublic

Description

These were added to VE init >10 years ago (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/72069) as VE was responsible for introducing the longer section edit messages ("edit" -> "edit source" or "edit | edit source"). As it is part of the init module in loads immediately on any page that supports VE, so upstreaming this change and running it always will have little effect.

Event Timeline

Esanders added a subscriber: TripleCamera2022.

See also:

The layout issue still exists: The "Edit template data" button is split into two lines.

https://www.mediawiki.org/wiki/Template:!!?uselang=en&safemode=1

T339806_reopen.png (568×753 px, 54 KB)

Besides, the current style may be misleading: "Template parameters" is not a heading, but a caption.

Change #1139475 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] Upstream editsection wrapping rules from VE

https://gerrit.wikimedia.org/r/1139475

Change #1139476 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Remove mw-editsection styles upstreamed to core

https://gerrit.wikimedia.org/r/1139476

Change #1139475 merged by jenkins-bot:

[mediawiki/core@master] Upstream editsection wrapping rules from VE

https://gerrit.wikimedia.org/r/1139475

Change #1139476 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove mw-editsection styles upstreamed to core

https://gerrit.wikimedia.org/r/1139476

matmarex assigned this task to Esanders.
matmarex subscribed.