Page MenuHomePhabricator
Create Task
Maniphest T389702

TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.21/extensions/WikiLambda/includes/PublicAPI/PublicApiRun.php(55)
#0/srv/mediawiki/php-1.44.0-wmf.21/extensions/WikiLambda/includes/PublicAPI/PublicApiRun.php(55)property_exists(null, string)
#1/srv/mediawiki/php-1.44.0-wmf.21/extensions/WikiLambda/includes/ActionAPI/WikiLambdaApiBase.php(75)MediaWiki\Extension\WikiLambda\PublicAPI\PublicApiRun->run()
#2/srv/mediawiki/php-1.44.0-wmf.21/includes/api/ApiMain.php(2005)MediaWiki\Extension\WikiLambda\ActionAPI\WikiLambdaApiBase->execute()
#3/srv/mediawiki/php-1.44.0-wmf.21/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#4/srv/mediawiki/php-1.44.0-wmf.21/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#5/srv/mediawiki/php-1.44.0-wmf.21/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#6/srv/mediawiki/php-1.44.0-wmf.21/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#7/srv/mediawiki/php-1.44.0-wmf.21/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#8/srv/mediawiki/w/api.php(3)require(string)
#9{main}
Impact
Notes

Details

Request URL
https://www.wikifunctions.org/w/api.php?action=*&format=*&function_call=*
SubjectRepoBranchLines +/-
ApiFunctionCall: Don't explode PHP if the user input is invalid JSONmediawiki/extensions/WikiLambdamaster+13 -1
PublicApiRun: Don't explode PHP if the user input is invalid JSONmediawiki/extensions/WikiLambdamaster+15 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Mar 22 2025, 12:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2025, 12:09 AM
Maintenance_bot added a project: Abstract Wikipedia team.Mar 22 2025, 12:30 AM
Jdforrester-WMF moved this task from To Triage to 25Q4 (Apr–Jun) on the Abstract Wikipedia team board.Mar 26 2025, 4:52 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Reedy moved this task from Untriaged to Mar 2025 on the Wikimedia-production-error board.Mar 31 2025, 10:47 PM
Krinkle moved this task from Mar 2025 to Jan-Mar 2025 on the Wikimedia-production-error board.Apr 1 2025, 2:05 AM
gerritbot added a comment.Apr 1 2025, 3:27 PM

Change #1133168 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] PublicApiRun: Don't explode PHP if the user input is invalid JSON

https://gerrit.wikimedia.org/r/1133168

gerritbot added a project: Patch-For-Review.Apr 1 2025, 3:27 PM
Jdforrester-WMF claimed this task.Apr 1 2025, 3:27 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.Apr 2 2025, 2:56 PM
gerritbot added a comment.Apr 2 2025, 3:04 PM

Change #1133168 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] PublicApiRun: Don't explode PHP if the user input is invalid JSON

https://gerrit.wikimedia.org/r/1133168

Maintenance_bot removed a project: Patch-For-Review.Apr 2 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 2 2025, 4:00 PM
DSantamaria changed the task status from Open to In Progress.Apr 7 2025, 7:56 AM
Reedy added a comment.Apr 14 2025, 5:36 PM

Still seems to be broken, just some minor line changes in the middle?

Error
normalized_message
[{reqId}] {exception_url}   TypeError: property_exists(): Argument #1 ($object_or_class) must be of type object|string, null given
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.24/extensions/WikiLambda/includes/ActionAPI/ApiFunctionCall.php(55)
#0/srv/mediawiki/php-1.44.0-wmf.24/extensions/WikiLambda/includes/ActionAPI/ApiFunctionCall.php(55)property_exists(null, string)
#1/srv/mediawiki/php-1.44.0-wmf.24/extensions/WikiLambda/includes/ActionAPI/WikiLambdaApiBase.php(82)MediaWiki\Extension\WikiLambda\ActionAPI\ApiFunctionCall->run()
#2/srv/mediawiki/php-1.44.0-wmf.24/includes/api/ApiMain.php(2005)MediaWiki\Extension\WikiLambda\ActionAPI\WikiLambdaApiBase->execute()
#3/srv/mediawiki/php-1.44.0-wmf.24/includes/api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#4/srv/mediawiki/php-1.44.0-wmf.24/includes/api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#5/srv/mediawiki/php-1.44.0-wmf.24/includes/api/ApiEntryPoint.php(152)MediaWiki\Api\ApiMain->execute()
#6/srv/mediawiki/php-1.44.0-wmf.24/includes/MediaWikiEntryPoint.php(202)MediaWiki\Api\ApiEntryPoint->execute()
#7/srv/mediawiki/php-1.44.0-wmf.24/api.php(44)MediaWiki\MediaWikiEntryPoint->run()
#8/srv/mediawiki/w/api.php(3)require(string)
#9{main}
Impact
Notes
gerritbot added a comment.Apr 15 2025, 12:43 AM

Change #1136475 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiFunctionCall: Don't explode PHP if the user input is invalid JSON

https://gerrit.wikimedia.org/r/1136475

gerritbot added a project: Patch-For-Review.Apr 15 2025, 12:43 AM
gerritbot added a comment.Apr 15 2025, 4:12 AM

Change #1136475 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiFunctionCall: Don't explode PHP if the user input is invalid JSON

https://gerrit.wikimedia.org/r/1136475

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2025, 4:30 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.27; 2025-04-29); removed MW-1.44-notes (1.44.0-wmf.24; 2025-04-08).Apr 15 2025, 5:00 AM
Jdforrester-WMF mentioned this in T388251: PHP Warning: First parameter must either be an object or the name of an existing class.Apr 16 2025, 8:27 PM
Jdforrester-WMF added a project: Essential-Work.Apr 16 2025, 8:57 PM
DSantamaria subscribed.May 4 2025, 8:18 AM

@Jdforrester-WMF, this hasn't been deployed already?

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q4 (Apr–Jun)) board.May 7 2025, 10:00 PM
DSantamaria added a comment.May 12 2025, 4:58 PM

@Jdforrester-WMF and follow-up question, is it already solved?

Jdforrester-WMF closed this task as Resolved.May 13 2025, 9:42 PM
In T389702#10789550, @DSantamaria wrote:

@Jdforrester-WMF, this hasn't been deployed already?

This was deployed two weeks ago and seems to have fixed the issue, yes.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits