Page MenuHomePhabricator

Hard-deprecate mw.eventLog.inSample()
Closed, ResolvedPublic

Description

Background

mw.eventLog.inSample() was marked as deprecated just over 5 years ago in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/458864.

TODO

  • Replace uses of mw.eventLog.inSample() with mw.eventLog.eventInSample()
  • Hard-deprecate mw.eventLog.inSample()

Notes

  1. Uses of mw.eventLog.inSample()

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
phuedx renamed this task from Hard-deprecate mw.eventLog.inSample to Hard-deprecate mw.eventLog.inSample().Oct 12 2023, 4:46 PM

Change 965611 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/EventLogging@master] Remove in sample

https://gerrit.wikimedia.org/r/965611

Change 971421 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/WikimediaEvents@master] mw.eventLog.inSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/971421

Change 971425 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/NavigationTiming@master] mw.eventLog.inSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/971425

Change 971421 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] mw.eventLog.inSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/971421

Change 971425 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] mw.eventLog.inSample() -> pageviewInSample()

https://gerrit.wikimedia.org/r/971425

Change 965611 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Deprecate 'core.inSample' and introduce 'core.pageviewInSample'

https://gerrit.wikimedia.org/r/965611

This is Done™. I'm leaving this task open to track monitoring the client-side error logs during this week's train deployment.

This is Done™. I'm leaving this task open to track monitoring the client-side error logs during this week's train deployment.

… using the mw-js-deprecate dashboard here: https://grafana.wikimedia.org/d/000000037/mw-js-deprecate?orgId=1&refresh=1m&var-Step=24h&var-key=mw_eventLog_inSample

Following up on this:

There were 2 deprecation notices emitted (see https://grafana.wikimedia.org/d/000000037/mw-js-deprecate?orgId=1&refresh=1m&var-Step=24h&var-key=mw_eventLog_inSample&viewPanel=39) but they appear to have happened during the deployment. I'm guessing that these were emitted by an RL module that hadn't yet fallen out of the cache.

There don't appear to have been any errors associated with mw.eventLog.inSample.

phuedx claimed this task.