FederatedPropertiesErrorTest.php unit test has encoding issues and is blocking markup change
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Jdlrobson
	Jun 8 2023, 6:04 PM

Description

Hi there, we're keen to make a change to message boxes in mediawiki core (T326587) but when we make this change it breaks a unit test in Wikibase. I wrote a patch which provides a fix but perhaps there's a better way but haven't got any feedback from WMDE https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/913240

Please can you prioritize helping us unblock T326587)

Details

	Subject	Repo	Branch	Lines +/-
	Account for HTML encoding	mediawiki/extensions/Wikibase	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned Here: T326587: Replace core Message Box styles with Codex equivalents

Event Timeline

Jdlrobson created this task.Jun 8 2023, 6:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2023, 6:04 PM

Change 913240 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Wikibase@master] Account for HTML encoding

https://gerrit.wikimedia.org/r/913240

gerritbot added a project: Patch-For-Review.Jun 8 2023, 6:05 PM

@ItamarWMDE could you help me prioritize this task? Thanks in advance

Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptJun 8 2023, 6:07 PM

Maintenance_bot added a project: Wikidata.Jun 8 2023, 6:29 PM

Looks like the test that's blocking you relates to a feature that's currently missing a team to maintain its code. I've added the appropriate tag since I'm pretty sure it's clearly not something for the Wikidata team to look at.

Thank you @Tarrow!

WMDE-leszek subscribed.Jun 9 2023, 9:29 AM