Collapsible elements are invisible to browser search
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Tacsipacsi
	Jan 25 2023, 12:29 PM

Description

Steps to reproduce

Open https://www.mediawiki.org/w/index.php?title=Manual:Collapsible_elements&oldid=5581603
Using the browser search (⌃+F, ⌘+F etc.), search for is hidden.

Actual result

Two results are found, in the two code examples.

Expected result

Four results are found: two in the code examples, and two in the rendered examples.

Other information

At least in Chrome and many Chromium-based browsers, MobileFrontend fixed this in 1abe4bd7dbd3b4001979a9bdb518f8d4d287a485 (T216789). The same fix should work here as well.

Keywords for searchability: collapse, collapsibility, template

Browsers supporting this feature: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Global_attributes/hidden#browser_compatibility

Chrome since 102 (and Chromium-based browsers), released in 2022
Firefox since 139, released in May 2025

Details

	Subject	Repo	Branch	Lines +/-
	jquery.makeCollapsible: Avoid extra borders etc. on un-rendered elements	mediawiki/core	master	+7 -3
	makeCollapsible: Expand when text is matched with browser find feature	mediawiki/core	master	+123 -59

Customize query in gerrit

Related Objects

Mentioned Here: T216789: Use display locking to allow browser's native "Find in page" function to work with collapsed sections
rEMFR1abe4bd7dbd3: Make sections expandable by find-in-page

Event Timeline

Tacsipacsi created this task.Jan 25 2023, 12:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2023, 12:29 PM

Esanders subscribed.Oct 21 2023, 10:14 AM

Change 967556 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] makeCollapsible: Expand when text is matched with browser find feature

https://gerrit.wikimedia.org/r/967556

gerritbot added a project: Patch-For-Review.Oct 21 2023, 12:28 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/a06975bb3f/wiki/Collapsible

Unfortunately this won't work with how we current collapse tables, as content-visibility can't be used to hide table structure, but it will work in all other cases.

In T327893#9270203, @Esanders wrote:

Unfortunately this won't work with how we current collapse tables, as content-visibility can't be used to hide table structure, but it will work in all other cases.

I realised we can force this to work with table cells, by turning them into not-table cells when hidden (using display:block)!

Demos:

~~https://patchdemo.wmflabs.org/wikis/a06975bb3f/wiki/Collapsible~~
~~https://patchdemo.wmflabs.org/wikis/a06975bb3f/wiki/Kim_Gyu-ri_(actress,_born_August_1979) (collapsed nav boxes at end of article)~~

Esanders added a subscriber: Quiddity.Oct 25 2023, 3:53 PM

Quiddity updated the task description. (Show Details)Sep 8 2024, 9:46 PM

Tacsipacsi updated the task description. (Show Details)Sep 10 2024, 9:03 PM

Novem_Linguae subscribed.Jun 17 2025, 8:13 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/8382623358/wiki/Collapsible

Requested on-wiki: https://en.wikipedia.org/wiki/Template_talk:Collapse_top#Archived_discussions_and_the_%E2%8C%98F_problem

Esanders added a subscriber: matmarex.Fri, Jun 20, 1:36 PM

isaacl subscribed.Sat, Jun 21, 10:18 PM

matmarex updated the task description. (Show Details)Mon, Jun 23, 8:17 PM

matmarex updated the task description. (Show Details)

Change #967556 merged by jenkins-bot:

[mediawiki/core@master] makeCollapsible: Expand when text is matched with browser find feature

https://gerrit.wikimedia.org/r/967556

Maintenance_bot removed a project: Patch-For-Review.Mon, Jun 23, 9:30 PM

Added to Tech News draft: https://meta.wikimedia.org/w/index.php?diff=28897533

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Tue, Jun 24, 4:01 PM

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Thu, Jun 26, 11:17 PM

@Esanders, probably instead of the specific fix for .wikitable.mw-collapsed, there should be a wider fix for .mw-collapsed [ hidden='until-found' ]. In Russian Wikipedia, we have already found a case with a visible border around a hidden element. I believe there are similar issues in every wiki project.

Trizek-WMF moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Thu, Jul 3, 3:28 PM

Change #1166234 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] jquery.makeCollapsible: Avoid extra borders etc. on un-rendered elements

https://gerrit.wikimedia.org/r/1166234

gerritbot added a project: Patch-For-Review.Thu, Jul 3, 5:47 PM

@putnik Could you please link some examples, so that we can make sure that this patch will work for them?

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/4494d98855/w/

Change #1166234 merged by jenkins-bot: