Page MenuHomePhabricator
Create Task
Maniphest T319379

Add option to not convert to MP3 via LAME
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
TheresNoTime
Authored By
TheresNoTime
Oct 5 2022, 8:41 AM
Tags
Referenced Files
F35553548: PhonosStoredFiles_IE.png
Oct 7 2022, 7:52 PM
F35553546: PhonosStoredFiles_FF.png
Oct 7 2022, 7:52 PM
F35553539: PhonosStoredFiles_Unset_Chrome.png
Oct 7 2022, 7:52 PM
F35553537: PhonosStoredFiles_True_Chrome.png
Oct 7 2022, 7:52 PM
F35553535: PhonosStoredFiles_False_Chrome.png
Oct 7 2022, 7:52 PM
Subscribers
Aklapper
GMikesell-WMF
MusikAnimal
• NRodriguez
TheresNoTime

Description

Add a configuration variable (PhonosStoreFilesAsMp3, default true) to optionally disable WAV --> MP3 conversion for the Larynx and eSpeak engines — some systems may be unable to use LAME (?) (and it makes it a little easier to test on Windows!)

Acceptance criteria

  • With $wgPhonosStoreFilesAsMp3 unset, the generated audio from Phonos should be a MP3 file
  • With $wgPhonosStoreFilesAsMp3 = true; in LocalSettings.php, the generated audio from Phonos should be a MP3 file
  • With $wgPhonosStoreFilesAsMp3 = false; in LocalSettings.php, the generated audio from Phonos should be a WAV file

Details

SubjectRepoBranchLines +/-
Remove $wgPhonosStoreFilesAsMp3mediawiki/extensions/Phonosmaster+5 -23
wgPhonosStoreFilesAsMp3: Add option to not convert to MP3 via LAMEmediawiki/extensions/Phonosmaster+25 -7
Customize query in gerrit

Related Objects

Event Timeline

TheresNoTime created this task.Oct 5 2022, 8:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2022, 8:41 AM
TheresNoTime added a project: Community-Tech (CommTech-Sprint-34).Oct 5 2022, 8:42 AM
TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-34) board.
TheresNoTime set the point value for this task to 2.
gerritbot added a comment.Oct 5 2022, 8:44 AM

Change 838727 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/Phonos@master] wgPhonosConvertToMp3: Add option to not convert to MP3 via LAME

https://gerrit.wikimedia.org/r/838727

gerritbot added a project: Patch-For-Review.Oct 5 2022, 8:44 AM
TheresNoTime moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-34) board.Oct 5 2022, 9:07 AM
gerritbot added a comment.Oct 6 2022, 7:26 PM

Change 838727 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] wgPhonosStoreFilesAsMp3: Add option to not convert to MP3 via LAME

https://gerrit.wikimedia.org/r/838727

TheresNoTime mentioned this in rEPHNa768954c2bda: wgPhonosStoreFilesAsMp3: Add option to not convert to MP3 via LAME.Oct 6 2022, 7:27 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 6 2022, 7:30 PM
TheresNoTime updated the task description. (Show Details)Oct 6 2022, 7:36 PM
TheresNoTime moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-34) board.
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 6 2022, 8:00 PM
GMikesell-WMF subscribed.Oct 7 2022, 7:52 PM

@TheresNoTime Validated the acceptance criteria are working as designed in Local as seen in the screenshots below via Chrome, Firefox, and IE. If there is anything else you would like me to test, just let me know. Otherwise, I'll be moving the task to product sign-off for now. Thanks!

With $wgPhonosStoreFilesAsMp3 unset, the generated audio from Phonos should be a MP3 file
With $wgPhonosStoreFilesAsMp3 = true; in LocalSettings.php, the generated audio from Phonos should be a MP3 file
With $wgPhonosStoreFilesAsMp3 = false; in LocalSettings.php, the generated audio from Phonos should be a WAV file

Chrome

PhonosStoredFiles_False_Chrome.png (1×1 px, 347 KB)
With $wgPhonosStoreFilesAsMp3 = false; in LocalSettings.php, the generated audio from Phonos should be a WAV file

PhonosStoredFiles_True_Chrome.png (1×1 px, 330 KB)
With $wgPhonosStoreFilesAsMp3 = true; in LocalSettings.php, the generated audio from Phonos should be a MP3 file

PhonosStoredFiles_Unset_Chrome.png (806×1 px, 266 KB)
With $wgPhonosStoreFilesAsMp3 unset, the generated audio from Phonos should be a MP3 file

Firefox-Same screenshots as Chrome. An example of being "false" in Firefox

PhonosStoredFiles_FF.png (545×1 px, 152 KB)
With $wgPhonosStoreFilesAsMp3 = false; in LocalSettings.php, the generated audio from Phonos should be a WAV file

IE -Same screenshots as Chrome. An example of being "false" in IE

PhonosStoredFiles_IE.png (564×1 px, 157 KB)
With $wgPhonosStoreFilesAsMp3 = false; in LocalSettings.php, the generated audio from Phonos should be a WAV file

GMikesell-WMF moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-34) board.Oct 7 2022, 7:53 PM
• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-34) board.Oct 11 2022, 10:08 AM
• JMcLeod_WMF moved this task from Done 🏁 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-34) board.
• JMcLeod_WMF edited projects, added Community-Tech (CommTech-Sprint-35); removed Community-Tech (CommTech-Sprint-34).Oct 11 2022, 10:26 AM
• JMcLeod_WMF moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-35) board.Oct 11 2022, 10:29 AM
MusikAnimal subscribed.Oct 12 2022, 1:26 AM

Should we make the same change to the GoogleEngine? GoogleEngine does not use Lame, and while avoiding Lame seems to be the intent of this task, the config setting implies you won't get MP3 when you still will with Google. It's easy to fix, if we want to ('audioEncoding' => 'LINEAR16' instead of => 'MP3').

• NRodriguez closed this task as Resolved.Oct 14 2022, 3:07 PM
• NRodriguez subscribed.

Should we make the same change to the GoogleEngine? GoogleEngine does not use Lame, and while avoiding Lame seems to be the intent of this task, the config setting implies you won't get MP3 when you still will with Google. It's easy to fix, if we want to ('audioEncoding' => 'LINEAR16' instead of => 'MP3').

@MusikAnimal open to doing that for a different task but resolving this one for now

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-35) board.Oct 17 2022, 7:08 PM
dom_walden mentioned this in T324239: Avoid storing empty files and show an error in Phonos.Dec 7 2022, 3:36 PM
gerritbot added a comment.Mar 6 2023, 5:56 PM

Change 894705 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/Phonos@master] Remove $wgPhonosStoreFilesAsMp3

https://gerrit.wikimedia.org/r/894705

Restricted Application edited projects, added Community-Tech; removed Community-Tech (CommTech-Sprint-35). · View Herald TranscriptMar 6 2023, 5:56 PM
gerritbot added a project: Patch-For-Review.Mar 6 2023, 5:56 PM
gerritbot added a comment.Mar 7 2023, 5:39 PM

Change 894705 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Remove $wgPhonosStoreFilesAsMp3

https://gerrit.wikimedia.org/r/894705

MusikAnimal mentioned this in rEPHNbedbb39f30ea: Remove $wgPhonosStoreFilesAsMp3.Mar 7 2023, 5:41 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 7 2023, 6:11 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.27; 2023-03-13); removed MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Mar 9 2023, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits