Page MenuHomePhabricator
Create Task
Maniphest T245634

CodeEditor button titles are double escaped
Closed, ResolvedPublic
Actions

Description

Title attribute of toolbar buttons of CodeEditor are escaped twice, so quotes are displayed as HTML entity codes instead of displaying the symbol '.

You can see that currently with French localisation: put your cursor over Outdent button, you’re seeing “Remonter l'indentation” instead of “Remonter l'indentation”.

Related Objects

Event Timeline

Pols12 created this task.Feb 19 2020, 3:27 PM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptFeb 19 2020, 3:27 PM
Ricordisamoa claimed this task.Aug 4 2020, 4:32 PM
Ricordisamoa subscribed.

https://gerrit.wikimedia.org/r/570387 a.k.a. e4d02b5e9a896546d63cd800ce6b0d77ae8ea190 seems to have fixed this, as checked via a local override with that patch reverted. Then the task may belong in WikiEditor (2010) instead.

TheDJ closed this task as Resolved.Aug 4 2020, 8:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits