Port minimal_glfw_gl to Emscripten #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds Emscripten (WebAssembly) support for the minimal_glfw_gl sample and aligns the existing sdl2_demo web entry point with a similar init/update pattern.
- Refactor
sdl2_demoweb loop to separate one-time init from per-frame update. - Extract GLFW logic in
minimal_glfw_glintoinit/deinit/updateAndRenderfor reuse. - Update build scripts and CI to include a new WebAssembly target and integrate
minimal_glfw_gl.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/sdl2_demo/src/main-web.zig | Refactored web loop to guard one-time init before update |
| samples/minimal_glfw_gl/src/minimal_glfw_gl.zig | Introduced init/deinit/shouldQuit/updateAndRender API |
| samples/minimal_glfw_gl/src/main.zig | Added native entrypoint that uses the new API |
| samples/minimal_glfw_gl/src/main-web.zig | Added web entrypoint and loop via Emscripten |
| samples/minimal_glfw_gl/src/build.zig | Switched root file to main.zig and added buildWeb step |
| build.zig | Exposed minimal_glfw_gl under samples.web |
| .github/workflows/main.yml | Added CI step to build wasm32-emscripten target |
Comments suppressed due to low confidence (1)
samples/minimal_glfw_gl/src/minimal_glfw_gl.zig:7
- [nitpick] Public API functions like
initshould have a doc comment describing the purpose ofgl_settingsand expected behavior.
pub fn init(gl_settings: struct {
hazeycode
force-pushed
the
port-web
branch
5 times, most recently
from
89acfae to
4969854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.