BREAKING: changed zd3d12 create*ShaderPipeline and MipmapGenerator to require shader bytecode #559
Conversation
desc instead of zd3d12 reaching out to read files. BREAKING: changed zd3d12 MipmapGenerator to require bytecode to be passed in instead of zd3d12 reaching out to read files. zd3d12 create*ShaderPipeline now generates the root signature if pRootSignature is null on desc fixes zig-gamedev#556
Agreed. Generally, I think we should be making samples/common smaller/non-existent. |
Ah, this explains a lot. |
|
@hazeycode do you know why all the windows d3d12 samples common imgui/vectormath instead of zgui/zmath? for example zig-gamedev/samples/triangle/src/triangle.zig Lines 10 to 11 in e15d5af |
Seems to be old code used by original Windows only version of zig-gamedev. I started on a win32_dx12 zgui backend so that the common imgui can be dropped... I'll dig that out. |
Yes, exactly. D3D12 samples were written when |
Removes all
std.fs.openFileAbsoluteout ofzd3d12.zig, but there still remain indirect file loading viagctx.wic_factory.CreateDecoderFromFilenameanddds_loading.zigCan be improved by extracting
csGenerateMipmapsout ofsamples/common/src/hlsl/common.hslsand put it into zd3d12 with a shader compilation step template.fixes #556