bodyEncoding: fix was setting 'accept-encoding' header, should be seeing 'accept-charset' header.

monkpow · monkpow · commit e1263d25fc82 · 2016-10-12T11:52:59.000-05:00
diff --git a/index.js b/index.js
@@ -82,7 +82,7 @@ module.exports = function proxy(host, options) {
       reqOpt.headers['content-length'] = getContentLength(bodyContent);
 
       if (bodyEncoding(options)) {
-        reqOpt.headers[ 'Accept-Encoding' ] = bodyEncoding(options);
+        reqOpt.headers['Accept-Charset'] = bodyEncoding(options);
       }
 
       var realRequest = parsedHost.module.request(reqOpt, function(rsp) {
diff --git a/test/bodyEncoding.js b/test/bodyEncoding.js
@@ -51,5 +51,22 @@ describe('body encoding', function() {
     });
 
   });
+
+
+  describe('when user sets reqBodyEncoding', function() {
+    it('should set the accepts-charset header', function(done) {
+      var app = express();
+      app.use(proxy('httpbin.org', {
+        reqBodyEncoding: 'utf-16'
+      }));
+      request(app)
+        .get('/headers')
+        .end(function(err, res) {
+          if (err) { throw err; }
+          assert.equal(res.body.headers['Accept-Charset'], 'utf-16');
+          done(err);
+        });
+    });
+  });
 });
 

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ module.exports = function proxy(host, options) {`
`82`	`82`	`reqOpt.headers['content-length'] = getContentLength(bodyContent);`
`83`	`83`
`84`	`84`	`if (bodyEncoding(options)) {`
`85`		`- reqOpt.headers[ 'Accept-Encoding' ] = bodyEncoding(options);`
	`85`	`+ reqOpt.headers['Accept-Charset'] = bodyEncoding(options);`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`var realRequest = parsedHost.module.request(reqOpt, function(rsp) {`