fix(compiler-core): KeepAlive should ignore comments #6026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony19
reviewed
May 29, 2022
node children should not be overwritten to keep comments in the build output
❌ Deploy Preview for vuejs-coverage failed.
|
|
@tony19 hi can you re-review my new changes please ? the re-request review button not working... |
tony19
reviewed
Jun 11, 2022
packages/compiler-core/__tests__/transforms/transformElement.spec.ts
Outdated
Show resolved
Hide resolved
tony19
approved these changes
Jun 11, 2022
|
Comments cannot be ignored directly |
|
https://staging-cn.vuejs.org/api/application.html#app-config-compileroptions comments need final rendering on dom |
yeah comments should be rendered on the dom and the same problem exists for other built-in components too like Transition ,Suspense and etc . i dont know if it is a bug or not. but if it is, i think the fix for that should be submitted in another pr , this one is to just fix the warning issue with the compiler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeepAlive does not ignore comments and the compiler throws an error when a component and a comment are wrapped with KeepAlive, which is obviously a bug.
error reproduction :
sfc.vuejs.org
thanks.