Skip to content

feat(vapor): vapor teleport #13082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: minor
Choose a base branch
from
Open

feat(vapor): vapor teleport #13082

wants to merge 35 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Mar 21, 2025 •
edited
Loading

Compiler Changes

  • In Vapor mode, automatically compile Teleport to VaporTeleport

Runtime Changes

  • Added VaporTeleport component with HMR support
  • Hydration is not yet supported
  • Extracted VaporFragment and DynamicFragment into separate files to avoid circular dependencies

Tests

  • Ported all test cases from packages/runtime-core/__tests__/components/Teleport.spec.ts
  • Added additional test cases for HMR functionality
  • In vapor-e2e-test:
    • Added test cases for VDOM Teleport rendering Vapor components
    • Added test cases for Vapor Teleport rendering VDOM components

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2025 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit fed71cb
🔍 Latest deploy log https://app.netlify.com/projects/vapor-repl/deploys/6854d5cd21410200087d071c
😎 Deploy Preview https://deploy-preview-13082--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 21, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13082

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13082

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13082

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13082

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13082

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13082

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13082

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13082

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13082

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13082

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13082

vue

npm i https://pkg.pr.new/vue@13082

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13082

commit: e01189f

@edison1105 edison1105 force-pushed the edison/feat/vaporTeleport branch from eb589c0 to b945079 Compare March 21, 2025 08:51
@edison1105 edison1105 force-pushed the edison/feat/vaporTeleport branch from 7d89e9d to 5c8f7ed Compare March 21, 2025 13:54
@edison1105 edison1105 changed the title feat(vapor): VaporTeleport feat(vapor): vapor teleport Mar 21, 2025
@edison1105 edison1105 force-pushed the edison/feat/vaporTeleport branch from d073b4f to 5b933f5 Compare March 26, 2025 14:14
@edison1105 edison1105 marked this pull request as ready for review March 27, 2025 07:50
@edison1105 edison1105 added the scope: vapor related to vapor mode label Apr 3, 2025
Base automatically changed from vapor to minor July 7, 2025 00:06
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 16, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.1 kB 29.8 kB 26.2 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.2 kB
vue.global.prod.js 162 kB 59.3 kB 52.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.5 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.7 kB (+106 B) 25.9 kB (+40 B) 23.6 kB (-20 B)
createVaporApp 21.2 kB (+97 B) 8.37 kB (+47 B) 7.66 kB (+39 B)
createSSRApp 60.3 kB 23.4 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.5 kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: vapor related to vapor mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edison1105