gracefully fail dynamic marker image imports #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this only happens in a vanilla js context as import() of non-js resources is unsupported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will gracefully handle errors from dynamic importing of marker icons.
This error is only appears when NOT using a js bundler (i.e. when using vanilla js and importmap).
In a vanilla js context
import()of non-js resources is unsupported and the current handling withinresetWebpackIcon(which seems only bundler related) raises errors which makes using this library impossible.This fix seems like a band aid, maybe it would be possible to avoid running
resetWebpackIconin a non-bundler context?