improved tests

mechelon · mechelon · commit 96342d40d3e3 · 2021-05-24T12:19:14.000+02:00
diff --git a/src/Endpoints/Block.php b/src/Endpoints/Block.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Endpoints;
 
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Notion;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
 use FiveamCode\LaravelNotionApi\Entities\Collections\BlockCollection;
@@ -29,15 +30,11 @@ public function children(): BlockCollection
             $this->url(Endpoint::BLOCKS . "/" . $this->blockId . "/children" . "?{$this->buildPaginationQuery()}")
         );
 
-        if ($response->failed())
-            throw NotionException::fromResponse($response);
-
         return new BlockCollection($response->json());
     }
 
     public function create(): array
     {
-        //toDo
-        throw new \Exception("not implemented yet");
+        throw new HandlingException("Not implemented");
     }
 }
diff --git a/src/Endpoints/Pages.php b/src/Endpoints/Pages.php
@@ -3,6 +3,7 @@
 namespace FiveamCode\LaravelNotionApi\Endpoints;
 
 use FiveamCode\LaravelNotionApi\Entities\Page;
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
 
 class Pages extends Endpoint implements EndpointInterface
@@ -22,22 +23,19 @@ public function find(string $pageId): Page
             $this->url(Endpoint::PAGES . "/" . $pageId)
         );
 
-        if ($response->failed())
-            throw NotionException::fromResponse($response);
-
         return new Page($response->json());
     }
 
     public function create(): array
     {
         //toDo
-        throw new \Exception("not implemented yet");
+        throw new HandlingException("Not implemented");
     }
 
 
     public function updateProperties(): array
     {
         //toDo
-        throw new \Exception("not implemented yet");
+        throw new HandlingException("Not implemented");
     }
 }
diff --git a/src/Endpoints/Users.php b/src/Endpoints/Users.php
@@ -38,10 +38,6 @@ public function find(string $userId): User
             $this->url(Endpoint::USERS . "/" . $userId)
         );
 
-        if ($response->failed())
-            throw NotionException::fromResponse($response);
-
-
         return new User($response->json());
     }
 }
diff --git a/tests/EndpointBlocksTest.php b/tests/EndpointBlocksTest.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Tests;
 
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use Illuminate\Support\Facades\Http;
 use FiveamCode\LaravelNotionApi\Entities\Blocks\Block;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
@@ -88,4 +89,13 @@ public function it_throws_a_notion_exception_not_found()
         \Notion::block("b55c9c91-384d-452b-81db-d1ef79372b11")->children();
     }
 
+    /** @test */
+    public function it_throws_a_handling_exception_not_implemented() {
+
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("Not implemented");
+
+        \Notion::block("")->create();
+    }
+
 }
diff --git a/tests/EndpointPagesTest.php b/tests/EndpointPagesTest.php
@@ -4,6 +4,7 @@
 
 use Carbon\Carbon;
 use FiveamCode\LaravelNotionApi\Entities\Page;
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Exceptions\NotionException;
 use Illuminate\Support\Facades\Http;
 use Orchestra\Testbench\TestCase;
@@ -86,4 +87,23 @@ public function it_throws_a_notion_exception_not_found()
         \Notion::pages()->find("b55c9c91-384d-452b-81db-d1ef79372b79");
     }
 
+
+    /** @test */
+    public function it_throws_a_handling_exception_not_implemented_for_create() {
+
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("Not implemented");
+
+        \Notion::pages()->create();
+    }
+
+    /** @test */
+    public function it_throws_a_handling_exception_not_implemented_for_update_properties() {
+
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("Not implemented");
+
+        \Notion::pages()->updateProperties();
+    }
+
 }
diff --git a/tests/NotionApiTest.php b/tests/NotionApiTest.php
@@ -2,6 +2,7 @@
 
 namespace FiveamCode\LaravelNotionApi\Tests;
 
+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;
 use FiveamCode\LaravelNotionApi\Notion;
 use Orchestra\Testbench\TestCase;
 
@@ -37,4 +38,14 @@ public function it_returns_notion_instance_with_set_token_and_connection()
         $this->assertInstanceOf(Notion::class, $notion);
         $this->assertNotEmpty($notion->getConnection());
     }
+
+
+    /** @test */
+    public function it_throws_a_handling_exception_invalid_version()
+    {
+        $this->expectException(HandlingException::class);
+        $this->expectExceptionMessage("invalid version for notion-api");
+
+        $notion = new Notion("secret_*", "v-does-not-exist");
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace FiveamCode\LaravelNotionApi\Endpoints;`
`4`	`4`
	`5`	`+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;`
`5`	`6`	`use FiveamCode\LaravelNotionApi\Notion;`
`6`	`7`	`use FiveamCode\LaravelNotionApi\Exceptions\NotionException;`
`7`	`8`	`use FiveamCode\LaravelNotionApi\Entities\Collections\BlockCollection;`
`@@ -29,15 +30,11 @@ public function children(): BlockCollection`
`29`	`30`	`$this->url(Endpoint::BLOCKS . "/" . $this->blockId . "/children" . "?{$this->buildPaginationQuery()}")`
`30`	`31`	`);`
`31`	`32`
`32`		`- if ($response->failed())`
`33`		`- throw NotionException::fromResponse($response);`
`34`		`-`
`35`	`33`	`return new BlockCollection($response->json());`
`36`	`34`	`}`
`37`	`35`
`38`	`36`	`public function create(): array`
`39`	`37`	`{`
`40`		`- //toDo`
`41`		`- throw new \Exception("not implemented yet");`
	`38`	`+ throw new HandlingException("Not implemented");`
`42`	`39`	`}`
`43`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`namespace FiveamCode\LaravelNotionApi\Endpoints;`
`4`	`4`
`5`	`5`	`use FiveamCode\LaravelNotionApi\Entities\Page;`
	`6`	`+use FiveamCode\LaravelNotionApi\Exceptions\HandlingException;`
`6`	`7`	`use FiveamCode\LaravelNotionApi\Exceptions\NotionException;`
`7`	`8`
`8`	`9`	`class Pages extends Endpoint implements EndpointInterface`
`@@ -22,22 +23,19 @@ public function find(string $pageId): Page`
`22`	`23`	`$this->url(Endpoint::PAGES . "/" . $pageId)`
`23`	`24`	`);`
`24`	`25`
`25`		`- if ($response->failed())`
`26`		`- throw NotionException::fromResponse($response);`
`27`		`-`
`28`	`26`	`return new Page($response->json());`
`29`	`27`	`}`
`30`	`28`
`31`	`29`	`public function create(): array`
`32`	`30`	`{`
`33`	`31`	`//toDo`
`34`		`- throw new \Exception("not implemented yet");`
	`32`	`+ throw new HandlingException("Not implemented");`
`35`	`33`	`}`
`36`	`34`
`37`	`35`
`38`	`36`	`public function updateProperties(): array`
`39`	`37`	`{`
`40`	`38`	`//toDo`
`41`		`- throw new \Exception("not implemented yet");`
	`39`	`+ throw new HandlingException("Not implemented");`
`42`	`40`	`}`
`43`	`41`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,10 +38,6 @@ public function find(string $userId): User`
`38`	`38`	`$this->url(Endpoint::USERS . "/" . $userId)`
`39`	`39`	`);`
`40`	`40`
`41`		`- if ($response->failed())`
`42`		`- throw NotionException::fromResponse($response);`
`43`		`-`
`44`		`-`
`45`	`41`	`return new User($response->json());`
`46`	`42`	`}`
`47`	`43`	`}`