remove unnecessary method from all collections

johguentner · johguentner · commit 139e305c1ec0 · 2021-05-14T23:57:27.000+02:00
diff --git a/src/Entities/BlockCollection.php b/src/Entities/BlockCollection.php
@@ -10,13 +10,6 @@
 
 class BlockCollection extends EntityCollection
 {
-
-    protected function setResponseData(array $responseData): void
-    {
-        parent::setResponseData($responseData);
-        $this->collectChildren();
-    }
-
     protected function collectChildren()
     {
         $this->collection = new Collection();
diff --git a/src/Entities/DatabaseCollection.php b/src/Entities/DatabaseCollection.php
@@ -10,13 +10,6 @@
 
 class DatabaseCollection extends EntityCollection
 {
-
-    protected function setResponseData(array $responseData): void
-    {
-        parent::setResponseData($responseData);
-        $this->collectChildren();
-    }
-
     protected function collectChildren()
     {
         $this->collection = new Collection();
diff --git a/src/Entities/EntityCollection.php b/src/Entities/EntityCollection.php
@@ -30,6 +30,7 @@ protected function setResponseData(array $reponseData): void
 
         $this->responseData = $reponseData;
         $this->fillFromRaw();
+        $this->collectChildren();
     }
 
     protected function fillFromRaw()
@@ -40,7 +41,6 @@ protected function fillFromRaw()
     protected function fillResult()
     {
         $this->rawResults = $this->responseData['results'];
-        $this->collectChildren();
     }
 
 
diff --git a/src/Entities/PageCollection.php b/src/Entities/PageCollection.php
@@ -10,22 +10,11 @@
 
 class PageCollection extends EntityCollection
 {
-
-    protected function setResponseData(array $responseData): void
-    {
-        parent::setResponseData($responseData);
-        $this->collectChildren();
-    }
-
     protected function collectChildren()
     {
         $this->collection = new Collection();
         foreach ($this->rawResults as $pageChild) {
             $this->collection->add(new Page($pageChild));
         }
     }
-
-
-
-
 }
diff --git a/src/Entities/UserCollection.php b/src/Entities/UserCollection.php
@@ -10,13 +10,6 @@
 
 class UserCollection extends EntityCollection
 {
-
-    protected function setResponseData(array $responseData): void
-    {
-        parent::setResponseData($responseData);
-        $this->collectChildren();
-    }
-
     protected function collectChildren()
     {
         $this->collection = new Collection();

Original file line number	Diff line number	Diff line change
`@@ -10,13 +10,6 @@`
`10`	`10`
`11`	`11`	`class BlockCollection extends EntityCollection`
`12`	`12`	`{`
`13`		`-`
`14`		`- protected function setResponseData(array $responseData): void`
`15`		`- {`
`16`		`- parent::setResponseData($responseData);`
`17`		`- $this->collectChildren();`
`18`		`- }`
`19`		`-`
`20`	`13`	`protected function collectChildren()`
`21`	`14`	`{`
`22`	`15`	`$this->collection = new Collection();`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,7 @@ protected function setResponseData(array $reponseData): void`
`30`	`30`
`31`	`31`	`$this->responseData = $reponseData;`
`32`	`32`	`$this->fillFromRaw();`
	`33`	`+ $this->collectChildren();`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`protected function fillFromRaw()`
`@@ -40,7 +41,6 @@ protected function fillFromRaw()`
`40`	`41`	`protected function fillResult()`
`41`	`42`	`{`
`42`	`43`	`$this->rawResults = $this->responseData['results'];`
`43`		`- $this->collectChildren();`
`44`	`44`	`}`
`45`	`45`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -10,22 +10,11 @@`
`10`	`10`
`11`	`11`	`class PageCollection extends EntityCollection`
`12`	`12`	`{`
`13`		`-`
`14`		`- protected function setResponseData(array $responseData): void`
`15`		`- {`
`16`		`- parent::setResponseData($responseData);`
`17`		`- $this->collectChildren();`
`18`		`- }`
`19`		`-`
`20`	`13`	`protected function collectChildren()`
`21`	`14`	`{`
`22`	`15`	`$this->collection = new Collection();`
`23`	`16`	`foreach ($this->rawResults as $pageChild) {`
`24`	`17`	`$this->collection->add(new Page($pageChild));`
`25`	`18`	`}`
`26`	`19`	`}`
`27`		`-`
`28`		`-`
`29`		`-`
`30`		`-`
`31`	`20`	`}`