Skip to content

Fixed output_buffer purging error. #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2019
Merged

Fixed output_buffer purging error. #935

merged 1 commit into from
Jun 12, 2019

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Jun 12, 2019

Resolves #934

@jgebal jgebal added the bugfix label Jun 12, 2019
@jgebal jgebal added this to the v3.1.7 milestone Jun 12, 2019
PhilippSalvisberg
PhilippSalvisberg reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@PhilippSalvisberg PhilippSalvisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm reviewing it.

@PhilippSalvisberg
Copy link
Member

Good idea to change names of the output buffer tables. This ensures that code that uses this tables will fail.

PhilippSalvisberg
PhilippSalvisberg approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@PhilippSalvisberg PhilippSalvisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed it locally and run all tests sucessfully.
Additionally I used it from the SQL Developer extension. Worked there as well.
Looks good. Thanks a lot!

@PhilippSalvisberg PhilippSalvisberg merged commit bd14e43 into develop Jun 12, 2019
@jgebal jgebal deleted the feature/fix_output_buffer_cleanup branch June 17, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes

@lwasylow lwasylow Awaiting requested review from lwasylow

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
v3.1.7
Development

Successfully merging this pull request may close these issues.

cleanup_buffer fails if realtime_reporter is used
2 participants
@jgebal @PhilippSalvisberg