Fixed mainet default value

m-tymchyk · m-tymchyk · commit abfa6f086d7d · 2018-02-13T16:22:24.000+02:00
diff --git a/lib/init.js b/lib/init.js
@@ -1,43 +1,49 @@
 "use strict";
-var axios = require('axios');
+const axios = require('axios');
 const querystring = require('querystring');
 
-const url = 'https://api.etherscan.io';
-const testUrls = {
-  // old default defaults to rinkeb
-  'ropsten': 'https://ropsten.etherscan.io',
-  'kovan': 'https://kovan.etherscan.io',
-  'rinkeby': 'https://rinkeby.etherscan.io'
+const MAIN_API_URL = 'https://api.etherscan.io';
+const TESTNET_API_URL_MAP = {
+  ropsten: 'https://ropsten.etherscan.io',
+  kovan: 'https://kovan.etherscan.io',
+  rinkeby: 'https://rinkeby.etherscan.io'
 };
 
 /**
  * @module etherscan/api
  */
 
-// chain is for testnet (ropsten, rinkeby, kovan)
+/**
+ * @param {string} apiKey - (optional) Your Etherscan APIkey
+ * @param {string} chain - (optional) Testnet chain keys [ropsten, rinkeby, kovan]
+ */
 module.exports = function (apiKey, chain) {
 
   if (!apiKey) {
     apiKey = 'YourApiKeyToken';
   }
 
+  /**
+   * @param {string} chain
+   * @returns {string}
+   */
   function pickChainUrl(chain) {
-    if (!chain) {
-      return url;
-    }
-
-    if (!testUrls[chain]) {
-      throw Error('Chain missing ' + chain);
+    if (!chain || !TESTNET_API_URL_MAP[chain]) {
+      return MAIN_API_URL;
     }
 
-    return testUrls[chain];
+    return TESTNET_API_URL_MAP[chain];
   }
 
   var client = axios.create({
     baseURL: pickChainUrl(chain),
     timeout: 3000
   });
 
+  /**
+   * @param query
+   * @returns {Promise<any>}
+   */
   function getRequest(query) {
     return new Promise(function (resolve, reject) {
       client.get('/api?' + query)
diff --git a/test/index-test.js b/test/index-test.js
@@ -1,11 +1,19 @@
 'use strict';
 const assert = require('chai').assert;
-describe('index.js', function() {
-  it('can be required', function( ){
+describe('index.js', function () {
+
+  it('can be required', function () {
     require('../.');
   });
-  it('has init', function( ){
+
+  it('has init', function () {
     var res = require('../.');
     assert.ok(res.init);
   });
+
+  it('init on mainnet', function () {
+    var client = require('../.');
+    assert.ok(client.init(null, 'mainnet'));
+  });
+
 });
