feat: Enforce Optionally Required Attributes Through Types #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #527
Bundle Size Analysis
|
43081j
reviewed
Mar 25, 2025
| export interface PreloadLink extends BaseLinkAttributes { | ||
| rel: 'preload' | 'modulepreload' | 'prefetch' | ||
| href: string | ||
| as: 'audio' | 'document' | 'embed' | 'fetch' | 'image' | |
There was a problem hiding this comment.
is this meant to exclude 'image' so the type isn't inferred as PreloadLink | ImagePreloadLink?
just like you did with FontPreloadLink / `'font'
There was a problem hiding this comment.
Thanks for the review, this is mostly AI generated as a proof of concept so there's likely issues.
Will take a look when I tackle this again but I think it's inheritly risky given the v2 stable was just released so likely being parked for a couple of months while I focus on other things.
Feel free to help out though if you're interested, can fast track it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#527
❓ Type of change
📚 Description