Skip to content

chore: fix default value in JSDoc for reportUnusedDisableDirectives #11409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025

Conversation

cherryblossom000
Copy link
Contributor

PR Checklist

Overview

The default value of the reportUnusedDisableDirectives linter option is 'warn', not 'off' (see ESLint docs). This PR fixes the JSDoc comment of that option to reflect this.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 18, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit aad5528
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/687a361cb41f0e0008f86232
😎 Deploy Preview https://deploy-preview-11409--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🔴 down 25 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

nx-cloud bot commented Jul 18, 2025

View your CI Pipeline Execution ↗ for commit aad5528

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 10s View ↗
nx run-many -t lint ✅ Succeeded 4m 26s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 19s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 1s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-18 12:08:08 UTC

@bradzacher bradzacher merged commit ca00714 into typescript-eslint:main Jul 19, 2025
63 of 64 checks passed
@cherryblossom000 cherryblossom000 deleted the patch-1 branch July 19, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants