-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
declare function acceptsVoidCallback(voidCallback: undefined | (() => void));
declare const maybePromiseCallback: undefined | (() => Promise<void>)
acceptsVoidCallback(maybePromiseCallback);
ESLint Config
module.exports = {
"rules": {
"@typescript-eslint/no-misused-promises": "error"
}
}
tsconfig
Expected Result
I expect that the 3rd line should report "Promise returned in function argument where a void return was expected"
Actual Result
There was no error on the 3rd line.
Additional Info
This continues the conversation from #5744 (comment).
The rule does already check arguments that have multiple call signatures, but it doesn't check whether it is a union of something that has call signatures and something that doesn't.
We should also try to ensure that complex test cases around (possibly multiple) spread args behave appropriately, including yucky things like
declare function acceptsVoidCallbacks(...voidCallbacks: Array<undefined | (() => void)>);
declare const maybePromiseCallback: undefined | (() => Promise<void>)
declare const voidCallback: () => void;
acceptsVoidCallbacks(voidCallback, undefined, ...[voidCallback, voidCallback], ...[maybePromiseCallback], ...[voidCallback]);
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin