-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuedocumentationDocumentation ("docs") that needs adding/updatingDocumentation ("docs") that needs adding/updatinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugintestsanything to do with testinganything to do with testing
Description
Before You File a Documentation Request Please Confirm You Have Done The Following...
- I have looked for existing open or closed documentation requests that match my proposal.
- I have read the FAQ and my problem is not listed.
Suggested Changes
We've had a number of docs issues where the errors reported on an example block were not correct. The big reason this occurs is a few reasons:
- we don't validate the examples at all
- it's really hard for a reviewer to visualise the errors (open pr, click netlify preview link, navigate to docs, pick example, click open in playground, preview errors - PHEW that's a lot of steps)
- we have no way to visualise changes to the errors over time - so changes to rule behaviour that may remove or add errors aren't tracked.
For each rule doc code block we should render a snapshot output for each of its code samples which is the result of running the rule+config on the snapshot.
We could even make this a test which enforces that "valid" examples have no errors.
This would go hand-in-hand with #8381 to allow us to pre-visualise the shiki output and would be a natural partner to #6994.
Affected URL(s)
docs/rules/*
JoshuaKGoldberg, Josh-Cena, auvred and kirkwaiblinger
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuedocumentationDocumentation ("docs") that needs adding/updatingDocumentation ("docs") that needs adding/updatinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugintestsanything to do with testinganything to do with testing