-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
I'm playing with ESQuery type inference and I just noticed that there is a selector that queries a node that cannot be represented by the current AST structure:
typescript-eslint/packages/eslint-plugin/src/rules/no-unused-vars.ts
Lines 315 to 319 in 920f909
// module declaration in module declaration should not report unused vars error | |
// this is workaround as this change should be done in better way | |
'TSModuleDeclaration > TSModuleDeclaration'( | |
node: TSESTree.TSModuleDeclaration, | |
): void { |
Little context:
- Why it was added:
Issue: [no-unused-var] False positive for nested namespace declaration #2573
Fix: fix(eslint-plugin): [no-unused-vars] don't report nested module declaration #3119 - Why it's not needed anymore:
fix(typescript-estree): account for namespace nesting in AST conversion #6272
If I entirely remove this listener, all tests still pass, so it's dead code
Coverage ☠️:

Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs