Skip to content

Repo: reuse newly added "is builtin symbol like" logic from type-utils #8234

New issue
New issue
Closed
#9462
Closed
Repo: reuse newly added "is builtin symbol like" logic from type-utils#8234
#9462
Labels
accepting prsGo ahead, send a pull request that resolves this issuegood first issueGood for newcomerslocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.refactorPRs that refactor code onlyrepo maintenancethings to do with maintenance of the repo, and not with code/docs
@auvred

Description

@auvred
auvred
opened on Jan 9, 2024

Suggestion

Followup for #8011 (comment)

We've added few utility functions to the packages/type-utils/src/builtinSymbolLikes.ts

Basically they contain the logic for determining whether a given type is a type from the TS default library or not

These files already contain similar logic, it'd be cool if we dedupe it!

typescript-eslint/packages/eslint-plugin/src/rules/no-implied-eval.ts

Lines 82 to 90 in 705370a

if (symbol && symbol.escapedName === FUNCTION_CONSTRUCTOR) {
const declarations = symbol.getDeclarations() ?? [];
for (const declaration of declarations) {
const sourceFile = declaration.getSourceFile();
if (services.program.isSourceFileDefaultLibrary(sourceFile)) {
return true;
}
}
}

typescript-eslint/packages/eslint-plugin/src/rules/no-implied-eval.ts

Lines 145 to 153 in 705370a

if (symbol) {
const declarations = symbol.getDeclarations() ?? [];
for (const declaration of declarations) {
const sourceFile = declaration.getSourceFile();
if (services.program.isSourceFileDefaultLibrary(sourceFile)) {
context.report({ node, messageId: 'noFunctionConstructor' });
return;
}
}

Let's label this issue as good first issue? Ref: #8011 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuegood first issueGood for newcomerslocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.refactorPRs that refactor code onlyrepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions