-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuepackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-pluginpreset config changeProposal for an addition, removal, or general change to a preset configProposal for an addition, removal, or general change to a preset config
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I have searched for related issues and found none that match my proposal.
- I have read the FAQ and my problem is not listed.
Description
no-unsafe-unary-minus
:
requiresTypeChecking: true, |
prefer-destructuring
: requiresTypeChecking: true, |
Both rules require type information, but they aren't listed here:
typescript-eslint/packages/eslint-plugin/src/configs/disable-type-checked.ts
Lines 10 to 56 in ee158a6
rules: { | |
'@typescript-eslint/await-thenable': 'off', | |
'@typescript-eslint/consistent-type-exports': 'off', | |
'@typescript-eslint/dot-notation': 'off', | |
'@typescript-eslint/naming-convention': 'off', | |
'@typescript-eslint/no-base-to-string': 'off', | |
'@typescript-eslint/no-confusing-void-expression': 'off', | |
'@typescript-eslint/no-duplicate-type-constituents': 'off', | |
'@typescript-eslint/no-floating-promises': 'off', | |
'@typescript-eslint/no-for-in-array': 'off', | |
'@typescript-eslint/no-implied-eval': 'off', | |
'@typescript-eslint/no-meaningless-void-operator': 'off', | |
'@typescript-eslint/no-misused-promises': 'off', | |
'@typescript-eslint/no-mixed-enums': 'off', | |
'@typescript-eslint/no-redundant-type-constituents': 'off', | |
'@typescript-eslint/no-throw-literal': 'off', | |
'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off', | |
'@typescript-eslint/no-unnecessary-condition': 'off', | |
'@typescript-eslint/no-unnecessary-qualifier': 'off', | |
'@typescript-eslint/no-unnecessary-type-arguments': 'off', | |
'@typescript-eslint/no-unnecessary-type-assertion': 'off', | |
'@typescript-eslint/no-unsafe-argument': 'off', | |
'@typescript-eslint/no-unsafe-assignment': 'off', | |
'@typescript-eslint/no-unsafe-call': 'off', | |
'@typescript-eslint/no-unsafe-enum-comparison': 'off', | |
'@typescript-eslint/no-unsafe-member-access': 'off', | |
'@typescript-eslint/no-unsafe-return': 'off', | |
'@typescript-eslint/non-nullable-type-assertion-style': 'off', | |
'@typescript-eslint/prefer-includes': 'off', | |
'@typescript-eslint/prefer-nullish-coalescing': 'off', | |
'@typescript-eslint/prefer-optional-chain': 'off', | |
'@typescript-eslint/prefer-readonly': 'off', | |
'@typescript-eslint/prefer-readonly-parameter-types': 'off', | |
'@typescript-eslint/prefer-reduce-type-parameter': 'off', | |
'@typescript-eslint/prefer-regexp-exec': 'off', | |
'@typescript-eslint/prefer-return-this-type': 'off', | |
'@typescript-eslint/prefer-string-starts-ends-with': 'off', | |
'@typescript-eslint/promise-function-async': 'off', | |
'@typescript-eslint/require-array-sort-compare': 'off', | |
'@typescript-eslint/require-await': 'off', | |
'@typescript-eslint/restrict-plus-operands': 'off', | |
'@typescript-eslint/restrict-template-expressions': 'off', | |
'@typescript-eslint/return-await': 'off', | |
'@typescript-eslint/strict-boolean-expressions': 'off', | |
'@typescript-eslint/switch-exhaustiveness-check': 'off', | |
'@typescript-eslint/unbound-method': 'off', | |
}, |
Impacted Configurations
disable-type-checked
Additional Info
I've also noticed two additional things:
- The
check-configs
tests don't check thedisable-type-checked
config (source) - It looks like the description of the
check-configs
andcheck-docs
scripts got lost from the contributing guidelines in this commit. I think it'd great to bring them back (e.g mention them here?)
I should open the issue for each of them?
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuepackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-pluginpreset config changeProposal for an addition, removal, or general change to a preset configProposal for an addition, removal, or general change to a preset config