Before You File a Proposal Please Confirm You Have Done The Following...

• I have searched for related issues and found none that match my proposal.
• I have searched the current rule list and found no rules that match my proposal.
• I have read the FAQ and my problem is not listed.

My proposal is suitable for this project

• I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Link to the rule's documentation

https://typescript-eslint.io/rules/no-unnecessary-condition

Description

The allowConstantLoopConditions option is disabled by default, because cases like while (shouldRun = true) are likely errors. But that means the rule option also flags cases like while (true). Which is more of a stylistic preference, I think.

How about making the option more granular:

• 'never': same as today's false
• 'only-simple': allow "simple" cases like true (a better name would be nice!)
• 'always': same as today's true

...and in future major version, breaking change to:

• current: 'never' is be the default value and aliased by false (to not be a breaking change)
• next: 'only-simple' becomes the default value

Fail

let shouldRun = true;

while (shouldRun = true) { /* ... */ }

Pass

while (true) { /* ... */ }

Additional Info

I stumbled onto this in https://github.com/JoshuaKGoldberg/template-typescript-node-package/pull/469/files#diff-e1ce717e1179a0db14e90ec5374768a206651ca807db58352991eb7895ed7c9cR64