-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuegood first issueGood for newcomersGood for newcomersrepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
Coming over from #6350: we had an issue with our React code caused by us using invalid HTML. Specifically, React was logging this:
Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
We should end-to-end test to make sure this doesn't happen on the homepage again. Right now we just test that the homepage has no accessibility issues detectable by aXe:
typescript-eslint/packages/website/tests/index.spec.ts
Lines 4 to 7 in 9ffdb05
test('Index', async ({ page }) => { | |
await page.goto('/'); | |
await new AxeBuilder({ page }).analyze(); | |
}); |
Playwright is able to listen to console messages. I propose we make a second end-to-end test that checks to make sure no console.error
calls happened.
It wouldn't surprise me if a library already exists for Playwright somewhere that does this...
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuegood first issueGood for newcomersGood for newcomersrepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs