-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.refactorPRs that refactor code onlyPRs that refactor code only
Milestone
Description
Overview
typescript-eslint/packages/typescript-estree/src/parser.ts
Lines 90 to 91 in 09c04fb
createDefaultProgram(code, extra)) || | |
createIsolatedProgram(code, extra) |
That last || createIsolatedProgram(code, extra)
should never be hit. We believe it was a just-in-case fallback added long ago that is no longer (and maybe never was) needed.
Removing that case may make #5855 easier.
Marking as accepting PRs with the caveat that everything still has to work as expected. Which may or may not be doable. Good luck! 😄
This issue is from a pairing I had with @bradzacher going over the parser internals.
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedlocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.refactorPRs that refactor code onlyPRs that refactor code only