-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
/*eslint @typescript-eslint/ban-ts-comment: ["error"]*/
// @ts-expect-error 👨👩👧👦
foo.bar
ESLint Config
// See a comment in Repro Code
module.exports = {
"rules": {}
}
tsconfig
Expected Result
Report an error because description length is actually 1.
Actual Result
Does not report any errors.
Additional Info
String.prototype.length
isn't not enough for this rule. We should to consider to use third party package like https://github.com/orling/grapheme-splitter .
"👨👩👧👦".length; // 11
Versions
package | version |
---|---|
@typescript-eslint/eslint-plugin |
5.38.0 |
@typescript-eslint/parser |
5.38.0 |
TypeScript |
4.8.3 |
ESLint |
8.15.0 |
node |
web |
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomerspackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin