-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
This week we didn't merge any publicly-facing PRs. However https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.29.0 was released as a minor bump instead of a patch bump. This was because #5190 was marked as a feat
instead of a chore
.
These private packages definitely should not contribute to our weekly release version calculation.
We need to look into if lerna can filter these out automatically so we don't need to be strict about the semantic commit labelling. I've been manually updating PR titles as I saw them - but we really shouldn't be relying on a manual process to ensure our automated process is correct.
rubiesonthesky and JoshuaKGoldbergrubiesonthesky
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs