-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
Right now the pre-push
hook in husky runs Prettier on everything, which takes many seconds:
$ git push
yarn run v1.22.19
$ yarn check-format
$ prettier --list-different "./**/*.{md,mdx,ts,mts,cts,js,cjs,mjs,tsx,jsx}"
Done in 19.43s.
Everything up-to-date
The repository already has a pre-commit
hook for formatting. It should be impossible for users to add poorly formatting code unless they manually --no-verify
. Is there a reason to keep pre-push
in addition to pre-commit
?
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs