-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedbugSomething isn't workingSomething isn't working
Milestone
Description
This was forgotten when we worked around #2573
For namespace foo { namespace bar {} }
we produce the following AST:
TSModuleDeclaration[id = foo] > TSModuleBlock > TSModuleDeclaration[id = bar] > TSModuleBlock
For namespace foo.bar {}
produces the following AST:
TSModuleDeclaration[id = foo] > TSModuleDeclaration[id = bar] > TSModuleBlock
The AST we produce is driven by the AST TS produces - they emit the nested module declaration, so our code does as well.
Ultimately however is pretty incorrect and does not correctly represent the code as written.
Instead we should emit an EntityName
, thus allowing TSQualifiedName
in the .id
:
TSModuleDeclaration[id = foo.bar] > TSModuleBlock
armano2, JoshuaKGoldberg and fisker
Metadata
Metadata
Assignees
Labels
ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedbugSomething isn't workingSomething isn't working