-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estreeIssues related to @typescript-eslint/typescript-estree
Milestone
Description
Code from #4129
namespace Bar {
export const bar = 123;
}
export namespace Foo {
export import TheBar = Bar;
}
I didn't know that export import
was even valid at all in TS.
Right now this will emit a TSImportEqualsDeclaration
with .isExported = true
.
This is wrong because it means that rules have to have special handling specifically for this case in order to understand TheBar
is exported.
We should breaking change fix the AST here so that the AST is instead ExportNamedDeclaration > TSImportEqualsDeclaration
to align with everything else.
MBuchalik and armano2
Metadata
Metadata
Assignees
Labels
ASTPRs and Issues about the AST structurePRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedThis change will require a new major version to be releasedpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estreeIssues related to @typescript-eslint/typescript-estree