Skip to content

Bug: [restrict-plus-operands] allowNumberAndString: false doesn't report when adding a bigint to a string #10715

@0x31

Description

@0x31

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.7.2&fileType=.tsx&code=PTAEHUEMCcDsGdSQEYHsCuAXUBLWA3SAGxwBNRUAHAU2kllPgCgjrsAzWAOXQFtlaoALygAFJABcoWHwHQANKGRT4maHgDmASmEA%2BJKADUSgNxMQoACKpq8WAHJsAdxiwWbUJwBCODXmwi4lLIvv6KyqCq6rDaegbGyCZAA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6aFfKsu4%2BWZLQD2paAEMmAE1QYA2uGw5E0aEOiQANAsVZFeyGPjwhAdwBysALYAjZQEEpAZS7MA5ujAAzQ8kTbsAL7%2BALoKQQFAA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

// Warns about invalid operands
let fnNumber = (a: number, b: string) => a + b;
// Doesn't warn
let fnBigint = (a: bigint, b: string) => a + b;

ESLint Config

{
  "rules": {
    "@typescript-eslint/restrict-plus-operands": [
      "error",
      {
          "allowNumberAndString": false
      }
    ]
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

I expected that the 4th line should report the error "Operands of '+' operations must be a number or string, allowing a string + any of: any, boolean, null, RegExp, undefined. Got bigint + string."

The docs for allowNumberAndString specifically mention supporting bigint:

Whether to allow bigint/number typed values and string typed values to be added together.

Actual Result

There was no error on the 4th line.

Additional Info

In restrict-plus-operands.ts, line 221 should compare otherType to ts.TypeFlags.NumberLike | ts.TypeFlags.BigIntLike instead of just ts.TypeFlags.NumberLike.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions