-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
declare const maybeArr: string[] | undefined;
declare const arr: string[];
// fails correctly
for (const item in arr) {}
// should fail, same with `T[] | null`
for (const item in maybeArr) {}
// potentially suggest/autofix to the following?
for (const item of maybeArr ?? []) {}
ESLint Config
module.exports = {
parser: "@typescript-eslint/parser",
rules: {
"@typescript-eslint/no-for-in-array": "error",
},
};
tsconfig
Expected Result
I expected the rule to report, as it doesn't make sense to iterate null
or undefined
. A fixer would be nice (in general, not just for this special case) since most of the time, the intent is to use for-of
.
Actual Result
The rule fails to catch these cases.
Additional Info
Currently, the rule checks specifically for an array or union of arrays. I think this can be expanded to a union with an array and potentially null
and undefined
.
JoshuaKGoldberg
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin