-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
interface Box {
value: string;
}
declare function getFallbackBox(): Box;
declare const defaultBox: Box | undefined;
defaultBox || getFallbackBox();
// ~~
// Prefer using nullish coalescing operator ...
defaultBox ? defaultBox : getFallbackBox();
// No error :(
ESLint Config
module.exports = {
"rules": {
"@typescript-eslint/prefer-nullish-coalescing": "error"
}
}
tsconfig
Expected Result
Both the ||
or and the ?:
ternary should report.
Actual Result
Only the ||
or reports.
Additional Info
Ternary support was added in #4905, but seems limited to more strict cases of both undefined
and null
being checked?
Split out of #10218 (comment).
💖
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuebugSomething isn't workingSomething isn't workinglocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin