-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
It's not clear what these test cases are attempting to test.
typescript-eslint/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
Lines 137 to 140 in 2e2433b
` | |
let numbers = [1, 2, 3]; | |
String(...a); | |
`, |
typescript-eslint/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
Lines 280 to 294 in 2e2433b
{ | |
code: ` | |
let objects = [{}, {}]; | |
String(...objects); | |
`, | |
errors: [ | |
{ | |
data: { | |
certainty: 'will', | |
name: '...objects', | |
}, | |
messageId: 'baseToString', | |
}, | |
], | |
}, |
These test cases get in the way of changes necessary for #10430 and #8585
Additional Info
No response
JoshuaKGoldberg
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.repo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs