-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Update openapi.yaml file in src/libs/Cohere directory #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/libs/Cohere/openapi.yaml (2)
1550-1561
: Newimages
field added to the schemaThe addition of the
images
field enhances the API's capabilities to handle image data. Here are some observations:
- The field is correctly defined as an array with proper constraints (minItems and maxItems both set to 1).
- The item type is specified as a string, which aligns with the data URI format mentioned in the description.
- The description provides clear guidelines on the accepted formats (JPEG or PNG) and size limit (5MB).
Consider adding an example data URI in the description to further clarify the expected input format for users.
1550-1561
: Consider simplifying thex-fern-audiences
propertyThe
x-fern-audiences
property is defined twice, once for theimages
array and once for its items. This might be redundant.Consider removing the
x-fern-audiences
property from the items definition to avoid duplication:images: maxItems: 1 minItems: 1 type: array items: type: string writeOnly: true - x-fern-audiences: - - public description: "An array of image data URIs for the model to embed. Maximum number of images per call is `1`.\n\nThe image must be a valid [data URI](https://developer.mozilla.org/en-US/docs/Web/URI/Schemes/data). The image must be in either `image/jpeg` or `image/png` format and has a maximum size of 5MB." x-fern-audiences: - publicThis change maintains the same functionality while reducing redundancy in the schema.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (3)
src/libs/Cohere/Generated/Cohere.CohereApi.Embed.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereApi.Embed.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.EmbedRequest.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Cohere/openapi.yaml (1 hunks)
🔥 Files not summarized due to errors (1)
- src/libs/Cohere/openapi.yaml: Error: Server error: no LLM provider could handle the message
🧰 Additional context used
🔇 Additional comments (1)
src/libs/Cohere/openapi.yaml (1)
1550-1561
: Verify documentation and examples for new image embedding featureThe addition of the
images
field suggests that the API is being extended to support image embedding alongside text embedding. This is a significant feature addition that may have implications for other parts of the API or documentation.Please ensure that:
- The API documentation is updated to reflect this new capability.
- Example requests and responses including image embedding are provided in the documentation.
- Any client libraries or SDKs are updated to support this new feature.
- The API versioning strategy (if any) is considered to manage this feature addition.
To help verify the documentation updates, you can run the following script:
This script will help identify if the necessary documentation updates have been made to support the new image embedding feature.
Summary by CodeRabbit