-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Extend ImageUrl schema with optional detail property and update url description #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe OpenAPI specification for the Cohere API was updated by extending the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant CohereAPI
Client->>CohereAPI: Submit ImageUrl with url and optional detail property
CohereAPI-->>Client: Process image using specified detail ("auto", "low", "high") and respond
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/Cohere/openapi.yaml (1)
15906-15907
: Use a YAML block scalar for theurl
descriptionThe inline quoted description with a trailing
\n
is harder to read and maintain. Convert it to a block scalar for clarity and consistency.@@ properties: - url: - type: string - description: "URL of an image. Can be either a base64 data URI or a web URL.\n" + url: + type: string + description: | + URL of an image. Can be either a base64 data URI or a web URL.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
src/libs/Cohere/Generated/Cohere.Models.ImageContent.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ImageUrl.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ImageUrlDetail.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/JsonConverters.ImageUrlDetail.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/JsonConverters.ImageUrlDetailNullable.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/JsonSerializerContext.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml
(1 hunks)
🔇 Additional comments (1)
src/libs/Cohere/openapi.yaml (1)
15898-15904
: Specify schema default fordetail
to match documentation and simplify descriptionThe description claims that
"auto"
is the default, but there's nodefault
field in the schema. Without it, client code generators and validators won’t assume"auto"
. Add adefault: auto
entry. Optionally, switch to a YAML block scalar to avoid inline escaping.[raise_critical_issue, suggest_optional_refactor]
@@ properties: - detail: - enum: - - auto - - low - - high - type: string - description: "Controls the level of detail in image processing. \"auto\" is the default and lets the system choose, \"low\" is faster but less detailed, and \"high\" preserves maximum detail. You can save tokens and speed up responses by using detail: \"low\".\n" + detail: + type: string + enum: + - auto + - low + - high + default: auto + description: | + Controls the level of detail in image processing. "auto" is the default and lets the system choose, + "low" is faster but less detailed, and "high" preserves maximum detail. You can save tokens + and speed up responses by using detail: "low".
Summary by CodeRabbit
New Features
Documentation