-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Update openapi.yaml file in src/libs/Cohere directory #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
src/libs/Cohere/openapi.yaml (1)
11551-11551
: Consider consistent property naming across versions.The JSON schema documentation uses different property names:
schema
in one versionjson_schema
in another versionWhile the documentation content is excellent, consider using consistent property names to avoid confusion.
Also applies to: 12280-12280
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (20)
src/libs/Cohere/Generated/Cohere.CohereApi.Chat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereApi.Embed.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereApi.Embedv2.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereApi.Generate.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.CohereApi.Summarize.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereApi.Chat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereApi.Embed.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereApi.Embedv2.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereApi.Generate.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.ICohereApi.Summarize.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ChatRequest.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.ChatRequestSafetyMode.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.EmbedRequest.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.Embedv2Request.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.GenerateRequest.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.JSONResponseFormat.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.JSONResponseFormatSchema.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.JsonResponseFormatV2.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.JsonResponseFormatV2JsonSchema.g.cs
is excluded by!**/generated/**
src/libs/Cohere/Generated/Cohere.Models.SingleGeneration.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Cohere/openapi.yaml
(11 hunks)
🔥 Files not summarized due to errors (1)
- src/libs/Cohere/openapi.yaml: Error: Server error: no LLM provider could handle the message
🔇 Additional comments (5)
src/libs/Cohere/openapi.yaml (5)
207-207
: LGTM! Clear and comprehensive safety mode documentation.
The documentation effectively communicates the safety mode options, their limitations, model compatibility, and deployment options.
1295-1295
: LGTM! Comprehensive model documentation.
The model descriptions are thorough and consistent across endpoints, providing clear information about:
- Available models and their dimensions
- Performance trade-offs between model sizes
- Custom model support
Also applies to: 1568-1568, 4836-4836
9532-9532
: LGTM! Consistent deprecation notice.
The deprecation warning follows the same format as other deprecated endpoints, maintaining documentation consistency.
1530-1530
: Clarify the difference in embedding capabilities between v1 and v2.
There's an inconsistency in the endpoint descriptions:
- v1 mentions both "text and image embeddings"
- v2 only mentions "text embeddings"
Please clarify if this difference is intentional and if image embedding support differs between versions.
#!/bin/bash
# Search for any additional context about image embedding support
rg -i "image.*embed|embed.*image" --type yaml
Also applies to: 4794-4794
1273-1273
: LGTM! Clear deprecation notice with migration path.
The deprecation warning is well-documented with a migration guide link.
✅ Verification successful
Migration guide URL is consistently referenced
The migration guide URL is consistently used in the OpenAPI spec for both the generate and summarize endpoints, properly documenting the deprecation path.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the migration guide URL is accessible
curl -I "https://docs.cohere.com/docs/migrating-from-cogenerate-to-cochat"
Length of output: 32475
Script:
#!/bin/bash
# Verify the migration guide URL exists in docs
rg -i "migrating-from-cogenerate-to-cochat" --type yaml
Length of output: 683
@@ -12618,7 +12618,7 @@ components: | |||
- public | |||
x-fern-audiences: | |||
- public | |||
description: 'Only returned if `return_likelihoods` is set to `GENERATION` or `ALL`. The likelihood refers to the average log-likelihood of the entire specified string, which is useful for [evaluating the performance of your model](likelihood-eval), especially if you''ve created a [custom model](/docs/training-custom-models). Individual token likelihoods provide the log-likelihood of each token. The first token will not have a likelihood.' | |||
description: 'Only returned if `return_likelihoods` is set to `GENERATION` or `ALL`. The likelihood refers to the average log-likelihood of the entire specified string, which is useful for [evaluating the performance of your model](likelihood-eval), especially if you''ve created a [custom model](https://docs.cohere.com/docs/training-custom-models). Individual token likelihoods provide the log-likelihood of each token. The first token will not have a likelihood.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix broken documentation link.
The markdown link [evaluating the performance of your model](likelihood-eval)
appears to be broken. Please update with the correct URL.
Summary by CodeRabbit