-
-
Notifications
You must be signed in to change notification settings - Fork 762
Bulk action 2 fixes #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk action 2 fixes #2267
Conversation
Simplified to have a single filter for runId which accepts an array. This unifies the filtering by multiple runs (used by the waitpoint page) and the individual run filtering. It fixes a bug with bulk actions
|
WalkthroughThis change updates the handling of run ID filters across several modules in the codebase. The property for filtering by run IDs is renamed from 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (9)
🧰 Additional context used📓 Path-based instructions (7)apps/webapp/**/*.tsInstructions used from: Sources:
apps/webapp/**/*.{ts,tsx}Instructions used from: Sources:
**/*.{ts,tsx}Instructions used from: Sources:
{packages/core,apps/webapp}/**/*.{ts,tsx}Instructions used from: Sources:
**/*.tsxInstructions used from: Sources:
apps/webapp/**/*.test.{ts,tsx}Instructions used from: Sources:
**/*.test.{ts,tsx}Instructions used from: Sources:
🧠 Learnings (9)📓 Common learnings
apps/webapp/app/presenters/v3/WaitpointPresenter.server.ts (1)
apps/webapp/app/presenters/v3/BulkActionPresenter.server.ts (1)
apps/webapp/app/presenters/RunFilters.server.ts (4)
apps/webapp/test/runsRepository.test.ts (3)
apps/webapp/app/v3/services/bulk/BulkActionV2.server.ts (2)
apps/webapp/app/presenters/v3/NextRunListPresenter.server.ts (11)
apps/webapp/app/components/runs/v3/RunFilters.tsx (6)
apps/webapp/app/services/runsRepository.server.ts (1)
🧬 Code Graph Analysis (1)apps/webapp/app/services/runsRepository.server.ts (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
🔇 Additional comments (19)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
No description provided.