Skip to content

Add factory function to return format types #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented Apr 10, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

This PR adds a new factory function as format.Factory() as a helper method to consolidate the creation of format types of interface print.Format.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@khos2ow khos2ow added this to the v0.10.0 milestone Apr 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #243 into master will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
+ Coverage   80.36%   80.61%   +0.25%     
==========================================
  Files          30       31       +1     
  Lines        1594     1615      +21     
==========================================
+ Hits         1281     1302      +21     
  Misses        263      263              
  Partials       50       50              
Impacted Files Coverage Δ
internal/format/factory.go 100.00% <100.00%> (ø)

@khos2ow khos2ow merged commit c196c7c into terraform-docs:master Apr 10, 2020
@khos2ow khos2ow deleted the format-factory branch April 10, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants