Link formats documentation in README #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's great addition. What about adding a new item, called |
khos2ow
changed the title
khos2ow
added a commit
that referenced
this pull request
Feb 19, 2020
* Allow users to pass '--output-values' Pass empty string to CreateModule.outputValuePath * Fix bug causing 'pretty' tests to fail * Link formats documentation in README (#181) Co-authored-by: Khosrow Moossavi <khos2ow@gmail.com> * docs: Auto generate formats document from examples (#192) * Auto generate formats document from examples * fix lint issues * refactor: Add tfconf.Options to load Module with (#193) * Update Changelog * Allow users to pass '--output-values' Read the outputValuesPath from an env variable Use an env var with a path for '--output-values' Update Changelog Use an env var with a path for '--output-values' Update Changelog properly write output values for evrythng but yaml * Fix failing json+yaml tests * Remove unneeded code block from output.go * Remove unused import statement from output.go * Fix some noob mistakes * Create two flags to use for output value injection * Fix bug vanilla commands+build test to fail * Modify all tests and add new for outputvalues * Modify to include many output types * Optimize imports to appease checkfmt * Create loadOutputValues function * Fix linter issue * Code review fixes. Hopefully the final commit! * appease linter * Not allow sensitive output values to be injected * Remove trailing slash from tests * Remove default values from `--output-values-from` Co-authored-by: Martyn Ranyard <iMartyn@users.noreply.github.com> Co-authored-by: Khosrow Moossavi <khos2ow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
xinto the box(es) that apply:Description
Improves the discoverability of the output formats.
Issues Resolved
#180 (partially) - would be nice to do more, but this is easy and hopefully not contentious so I've done it :-)
Checklist
Put an
xinto all boxes that apply:Tests
(documentation-only PR)
make test.Documentation
Code Style
(no code additions/modifications)